Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue#343 #353

Merged
merged 8 commits into from
Nov 8, 2018
Merged

Fix for Issue#343 #353

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
23ef210
Fix for Issue#343
muraliQlogic Nov 4, 2018
81cb106
Reinstate changes and applied modified check to allow empty qualifier
muraliQlogic Nov 6, 2018
99fa708
Merge branch 'master' into Issue343
sduskis Nov 6, 2018
b4d0284
Update read-rows-acceptance-test.json
sduskis Nov 6, 2018
1087142
Update read-rows-acceptance-test.json
sduskis Nov 6, 2018
8adbe55
Merge branch 'master' into Issue343
JustinBeckwith Nov 7, 2018
6150727
Update chunktransformer.js
sduskis Nov 8, 2018
ca14a39
Update chunktransformer.js
sduskis Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/chunktransformer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,15 +248,6 @@ class ChunkTransformer extends Transform {
return;
}
}
if (chunk.familyName && !chunk.qualifier) {
this.destroy(
new TransformError({
message: 'A qualifier must be specified',
chunk,
})
);
return;
}
this.validateResetRow(chunk);
this.validateValueSizeAndCommitRow(chunk);
}
Expand Down
13 changes: 0 additions & 13 deletions system-test/read-rows-acceptance-test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,6 @@
"value": "",
"ts": 0
}]
}, {
"chunks": ["row_key: \"RK\"\nfamily_name: <\n value: \"A\"\n>\nqualifier: <\n value: \"C\"\n>\ntimestamp_micros: 99\nvalue: \"value-VAL_1\"\ncommit_row: false\n", "family_name: <\n value: \"B\"\n>\ntimestamp_micros: 98\nvalue: \"value-VAL_2\"\ncommit_row: true\n"],
"name": "invalid - new col family must specify qualifier",
"chunks_base64": ["CgJSSxIDCgFBGgMKAUMgYzILdmFsdWUtVkFMXzFIAA==", "EgMKAUIgYjILdmFsdWUtVkFMXzJIAQ=="],
"results": [{
"fm": "",
"rk": "",
"qual": "",
"label": "",
"error": true,
"value": "",
"ts": 0
}]
}, {
"chunks": ["row_key: \"RK\"\nfamily_name: <\n value: \"A\"\n>\nqualifier: <\n value: \"C\"\n>\ntimestamp_micros: 100\nvalue: \"value-VAL\"\ncommit_row: false\n", "commit_row: true\n"],
"name": "bare commit implies ts=0",
Expand Down
9 changes: 0 additions & 9 deletions test/chunktransformer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,15 +369,6 @@ describe('Bigtable/ChunkTransformer', function() {
commitRow: true,
});
});
it('should destroy when familyName without qualifier ', function(done) {
chunkTransformer.on('error', function() {
assert(destroySpy.called);
done();
});
processRowInProgressSpy.call(chunkTransformer, {
familyName: 'family',
});
});
it('should reset on resetRow ', function() {
const chunk = {resetRow: true};
chunkTransformer.processRowInProgress(chunk);
Expand Down