BREAKING CHANGE:rename the method name

googleapis · Oct 10, 2019 · b218883 · b218883
1 parent 20cccb0
commit b218883
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -731,12 +731,12 @@ class Datastore extends DatastoreRequest {
     return Datastore.isKey(value);
   }
 
-  keyToLegacyUrlsafe(key: entity.Key, locationPrefix?: string): Promise<string>;
-  keyToLegacyUrlsafe(
+  keyToLegacyUrlSafe(key: entity.Key, locationPrefix?: string): Promise<string>;
+  keyToLegacyUrlSafe(
     key: entity.Key,
     callback: KeyToLegacyUrlSafeCallback
   ): void;
-  keyToLegacyUrlsafe(
+  keyToLegacyUrlSafe(
     key: entity.Key,
     locationPrefix: string,
     callback: KeyToLegacyUrlSafeCallback
@@ -764,7 +764,7 @@ class Datastore extends DatastoreRequest {
    * const datastore = new Datastore();
    * const key = datastore.key(['Company', 'Google']);
    *
-   * datastore.keyToLegacyUrlsafe(key, (err, urlSafeKey) => {
+   * datastore.keyToLegacyUrlSafe(key, (err, urlSafeKey) => {
    *   if (err) {
    *     // Error handling omitted.
    *   }
@@ -779,7 +779,7 @@ class Datastore extends DatastoreRequest {
    * const key = datastore.key(['Task', 123]);
    * const locationPrefix = 's~';
    *
-   * datastore.keyToLegacyUrlsafe(key, locationPrefix, (err, urlSafeKey) => {
+   * datastore.keyToLegacyUrlSafe(key, locationPrefix, (err, urlSafeKey) => {
    *   if (err) {
    *     // Error handling omitted.
    *   }
@@ -793,10 +793,10 @@ class Datastore extends DatastoreRequest {
    * const key = datastore.key(['Task', 123]);
    * const locationPrefix = 's~';
    *
-   * const urlSafeKey = await datastore.keyToLegacyUrlsafe(key, locationPrefix);
+   * const urlSafeKey = await datastore.keyToLegacyUrlSafe(key, locationPrefix);
    * console.log(urlSafeKey);
    */
-  keyToLegacyUrlsafe(
+  keyToLegacyUrlSafe(
     key: entity.Key,
     locationPrefixOrCallback?: string | KeyToLegacyUrlSafeCallback,
     callback?: KeyToLegacyUrlSafeCallback

diff --git a/test/index.ts b/test/index.ts
@@ -625,7 +625,7 @@ describe('Datastore', () => {
     });
   });
 
-  describe('keyToLegacyUrlsafe', () => {
+  describe('keyToLegacyUrlSafe', () => {
     it('should convert key to url safe base64 string', () => {
       const key = new entity.Key({
         path: ['Task', 'Test'],
@@ -635,7 +635,7 @@ describe('Datastore', () => {
       (datastore.auth as any).getProjectId = (callback: Function) => {
         callback(null, 'project-id');
       };
-      datastore.keyToLegacyUrlsafe(key, (err, urlSafekey) => {
+      datastore.keyToLegacyUrlSafe(key, (err, urlSafekey) => {
         assert.ifError(err);
         assert.strictEqual(urlSafekey, base64EndocdedUrlsafeKey);
       });
@@ -652,7 +652,7 @@ describe('Datastore', () => {
       (datastore.auth as any).getProjectId = (callback: Function) => {
         callback(null, 'project-id');
       };
-      datastore.keyToLegacyUrlsafe(key, locationPrefix, (err, urlSafekey) => {
+      datastore.keyToLegacyUrlSafe(key, locationPrefix, (err, urlSafekey) => {
         assert.ifError(err);
         assert.strictEqual(urlSafekey, base64EndocdedUrlsafeKey);
       });
@@ -664,7 +664,7 @@ describe('Datastore', () => {
       (datastore.auth as any).getProjectId = (callback: Function) => {
         callback(error);
       };
-      datastore.keyToLegacyUrlsafe({} as entity.Key, (err, urlSafekey) => {
+      datastore.keyToLegacyUrlSafe({} as entity.Key, (err, urlSafekey) => {
         assert.strictEqual(err, error);
         assert.strictEqual(urlSafekey, undefined);
       });