Skip to content

Commit

Permalink
fix: Add a partner team as approvers for PRs (#686)
Browse files Browse the repository at this point in the history
* fix: Add a partner team as approvers for PRs 

Adding @googleapis/api-logging-partners to contain more people who can approve PRs

* Update sync-repo-settings.yaml

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update sync-repo-settings.yaml

* Update CODEOWNERS

* Update owlbot.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
losalex and gcf-owl-bot[bot] authored Dec 2, 2022
1 parent f259c48 commit 18d2fed
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@


# The yoshi-nodejs team is the default owner for nodejs repositories.
* @googleapis/yoshi-nodejs @googleapis/api-logging
* @googleapis/yoshi-nodejs @googleapis/api-logging @googleapis/api-logging-partners

# The github automation team is the default owner for the auto-approve file.
.github/auto-approve.yml @googleapis/github-automation
2 changes: 2 additions & 0 deletions .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,5 @@ permissionRules:
permission: admin
- team: jsteam
permission: push
- team: api-logging-partners
permission: push
2 changes: 1 addition & 1 deletion owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

common_templates = gcp.CommonTemplates()
templates = common_templates.node_library()
s.copy(templates, excludes=[".github/auto-label.yaml"])
s.copy(templates, excludes=[".github/auto-label.yaml", ".github/CODEOWNERS", ".github/sync-repo-settings.yaml"])
node.fix_hermetic()


Expand Down

0 comments on commit 18d2fed

Please sign in to comment.