chore!: upgrade to Node 14 (#1900)

* chore!: upgrade to Node 14 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sofia Leon <[email protected]> Co-authored-by: sofisl <[email protected]> Co-authored-by: Tom Andersen <[email protected]>
googleapis · Oct 3, 2023 · 1f5abb8 · 1f5abb8
1 parent 0afadef
commit 1f5abb8
Show file tree

Hide file tree

Showing 36 changed files with 188 additions and 185 deletions.
diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml
@@ -1,4 +1,4 @@
-# Copyright 2022 Google LLC
+# Copyright 2023 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -13,5 +13,5 @@
 # limitations under the License.
 docker:
   image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest
-  digest: sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
-# created: 2022-08-26T22:34:55.905845397Z
+  digest: sha256:8b6a07a38d1583d96b6e251ba208bd4ef0bc2a0cc37471ffc518841651d15bd6
+# created: 2023-09-25T22:18:27.595486267Z
diff --git a/.github/sync-repo-settings.yaml b/.github/sync-repo-settings.yaml
@@ -7,11 +7,10 @@ branchProtectionRules:
     requiredStatusCheckContexts:
       - "ci/kokoro: Samples test"
       - "ci/kokoro: System test"
-      - docs
       - lint
-      - test (12)
       - test (14)
       - test (16)
+      - test (18)
       - cla/google
       - windows
       - OwlBot Post Processor

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [12, 14, 16]
+        node: [14, 16, 18, 20]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

diff --git a/.kokoro/continuous/node12/common.cfg → .kokoro/continuous/node14/common.cfg b/.kokoro/continuous/node12/common.cfg → .kokoro/continuous/node14/common.cfg
diff --git a/.kokoro/continuous/node12/lint.cfg → .kokoro/continuous/node14/lint.cfg b/.kokoro/continuous/node12/lint.cfg → .kokoro/continuous/node14/lint.cfg
diff --git a/.kokoro/continuous/node12/samples-test.cfg → .kokoro/continuous/node14/samples-test.cfg b/.kokoro/continuous/node12/samples-test.cfg → .kokoro/continuous/node14/samples-test.cfg
diff --git a/.kokoro/continuous/node12/system-test.cfg → .kokoro/continuous/node14/system-test.cfg b/.kokoro/continuous/node12/system-test.cfg → .kokoro/continuous/node14/system-test.cfg
diff --git a/.kokoro/continuous/node12/test.cfg → .kokoro/continuous/node14/test.cfg b/.kokoro/continuous/node12/test.cfg → .kokoro/continuous/node14/test.cfg
diff --git a/.kokoro/presubmit/node12/common.cfg → .kokoro/presubmit/node14/common.cfg b/.kokoro/presubmit/node12/common.cfg → .kokoro/presubmit/node14/common.cfg
diff --git a/.kokoro/presubmit/node12/samples-test.cfg → .kokoro/presubmit/node14/samples-test.cfg b/.kokoro/presubmit/node12/samples-test.cfg → .kokoro/presubmit/node14/samples-test.cfg
diff --git a/.kokoro/presubmit/node12/system-test.cfg → .kokoro/presubmit/node14/system-test.cfg b/.kokoro/presubmit/node12/system-test.cfg → .kokoro/presubmit/node14/system-test.cfg
diff --git a/.kokoro/presubmit/node12/test.cfg → .kokoro/presubmit/node14/test.cfg b/.kokoro/presubmit/node12/test.cfg → .kokoro/presubmit/node14/test.cfg
diff --git a/.kokoro/release/publish.cfg b/.kokoro/release/publish.cfg
diff --git a/README.md b/README.md
@@ -117,7 +117,7 @@ also contains samples.
 
 ## Supported Node.js Versions
 
-Our client libraries follow the [Node.js release schedule](https://nodejs.org/en/about/releases/).
+Our client libraries follow the [Node.js release schedule](https://github.com/nodejs/release#release-schedule).
 Libraries are compatible with all current _active_ and _maintenance_ versions of
 Node.js.
 If you are using an end-of-life version of Node.js, we recommend that you update

diff --git a/dev/src/bulk-writer.ts b/dev/src/bulk-writer.ts
@@ -941,8 +941,8 @@ export class BulkWriter {
     );
 
     // Use the write with the longest backoff duration when determining backoff.
-    const highestBackoffDuration = pendingBatch.pendingOps.reduce((prev, cur) =>
-      prev.backoffDuration > cur.backoffDuration ? prev : cur
+    const highestBackoffDuration = pendingBatch.pendingOps.reduce(
+      (prev, cur) => (prev.backoffDuration > cur.backoffDuration ? prev : cur)
     ).backoffDuration;
     const backoffMsWithJitter = BulkWriter._applyJitter(highestBackoffDuration);
     const delayedExecution = new Deferred<void>();

diff --git a/dev/src/collection-group.ts b/dev/src/collection-group.ts
@@ -37,7 +37,7 @@ import {compareArrays} from './order';
  */
 export class CollectionGroup<
     AppModelType = firestore.DocumentData,
-    DbModelType extends firestore.DocumentData = firestore.DocumentData
+    DbModelType extends firestore.DocumentData = firestore.DocumentData,
   >
   extends Query<AppModelType, DbModelType>
   implements firestore.CollectionGroup<AppModelType, DbModelType>
@@ -197,13 +197,13 @@ export class CollectionGroup<
   withConverter(converter: null): CollectionGroup;
   withConverter<
     NewAppModelType,
-    NewDbModelType extends firestore.DocumentData = firestore.DocumentData
+    NewDbModelType extends firestore.DocumentData = firestore.DocumentData,
   >(
     converter: firestore.FirestoreDataConverter<NewAppModelType, NewDbModelType>
   ): CollectionGroup<NewAppModelType, NewDbModelType>;
   withConverter<
     NewAppModelType,
-    NewDbModelType extends firestore.DocumentData = firestore.DocumentData
+    NewDbModelType extends firestore.DocumentData = firestore.DocumentData,
   >(
     converter: firestore.FirestoreDataConverter<
       NewAppModelType,

diff --git a/dev/src/document-change.ts b/dev/src/document-change.ts
@@ -28,7 +28,7 @@ export type DocumentChangeType = 'added' | 'removed' | 'modified';
  */
 export class DocumentChange<
   AppModelType = firestore.DocumentData,
-  DbModelType extends firestore.DocumentData = firestore.DocumentData
+  DbModelType extends firestore.DocumentData = firestore.DocumentData,
 > implements firestore.DocumentChange<AppModelType, DbModelType>
 {
   private readonly _type: DocumentChangeType;

diff --git a/dev/src/document.ts b/dev/src/document.ts
@@ -40,7 +40,7 @@ import api = google.firestore.v1;
  */
 export class DocumentSnapshotBuilder<
   AppModelType = firestore.DocumentData,
-  DbModelType extends firestore.DocumentData = firestore.DocumentData
+  DbModelType extends firestore.DocumentData = firestore.DocumentData,
 > {
   /** The fields of the Firestore `Document` Protobuf backing this document. */
   fieldsProto?: ApiMapValue;
@@ -110,7 +110,7 @@ export class DocumentSnapshotBuilder<
  */
 export class DocumentSnapshot<
   AppModelType = firestore.DocumentData,
-  DbModelType extends firestore.DocumentData = firestore.DocumentData
+  DbModelType extends firestore.DocumentData = firestore.DocumentData,
 > implements firestore.DocumentSnapshot<AppModelType, DbModelType>
 {
   private _ref: DocumentReference<AppModelType, DbModelType>;
@@ -177,7 +177,7 @@ export class DocumentSnapshot<
    */
   static fromUpdateMap<
     AppModelType,
-    DbModelType extends firestore.DocumentData
+    DbModelType extends firestore.DocumentData,
   >(
     ref: firestore.DocumentReference<AppModelType, DbModelType>,
     data: UpdateMap
@@ -584,7 +584,7 @@ export class DocumentSnapshot<
  */
 export class QueryDocumentSnapshot<
     AppModelType = firestore.DocumentData,
-    DbModelType extends firestore.DocumentData = firestore.DocumentData
+    DbModelType extends firestore.DocumentData = firestore.DocumentData,
   >
   extends DocumentSnapshot<AppModelType, DbModelType>
   implements firestore.QueryDocumentSnapshot<AppModelType, DbModelType>
@@ -950,7 +950,7 @@ export class DocumentMask {
  */
 export class DocumentTransform<
   AppModelType = firestore.DocumentData,
-  DbModelType extends firestore.DocumentData = firestore.DocumentData
+  DbModelType extends firestore.DocumentData = firestore.DocumentData,
 > {
   /**
    * @private
@@ -1001,7 +1001,7 @@ export class DocumentTransform<
    */
   static fromUpdateMap<
     AppModelType,
-    DbModelType extends firestore.DocumentData
+    DbModelType extends firestore.DocumentData,
   >(
     ref: firestore.DocumentReference<AppModelType, DbModelType>,
     data: UpdateMap

diff --git a/dev/src/query-partition.ts b/dev/src/query-partition.ts
@@ -34,7 +34,7 @@ import api = protos.google.firestore.v1;
  */
 export class QueryPartition<
   AppModelType = firestore.DocumentData,
-  DbModelType extends firestore.DocumentData = firestore.DocumentData
+  DbModelType extends firestore.DocumentData = firestore.DocumentData,
 > implements firestore.QueryPartition<AppModelType, DbModelType>
 {
   private readonly _serializer: Serializer;

diff --git a/dev/src/reference.ts b/dev/src/reference.ts
@@ -128,9 +128,10 @@ const NOOP_MESSAGE = Symbol('a noop message');
  * @class DocumentReference
  */
 export class DocumentReference<
-  AppModelType = firestore.DocumentData,
-  DbModelType extends firestore.DocumentData = firestore.DocumentData
-> implements
+    AppModelType = firestore.DocumentData,
+    DbModelType extends firestore.DocumentData = firestore.DocumentData,
+  >
+  implements
     Serializable,
     firestore.DocumentReference<AppModelType, DbModelType>
 {
@@ -618,7 +619,7 @@ export class DocumentReference<
   withConverter(converter: null): DocumentReference;
   withConverter<
     NewAppModelType,
-    NewDbModelType extends firestore.DocumentData = firestore.DocumentData
+    NewDbModelType extends firestore.DocumentData = firestore.DocumentData,
   >(
     converter: firestore.FirestoreDataConverter<NewAppModelType, NewDbModelType>
   ): DocumentReference<NewAppModelType, NewDbModelType>;
@@ -675,7 +676,7 @@ export class DocumentReference<
    */
   withConverter<
     NewAppModelType,
-    NewDbModelType extends firestore.DocumentData = firestore.DocumentData
+    NewDbModelType extends firestore.DocumentData = firestore.DocumentData,
   >(
     converter: firestore.FirestoreDataConverter<
       NewAppModelType,
@@ -918,7 +919,7 @@ class FieldFilterInternal extends FilterInternal {
  */
 export class QuerySnapshot<
   AppModelType = firestore.DocumentData,
-  DbModelType extends firestore.DocumentData = firestore.DocumentData
+  DbModelType extends firestore.DocumentData = firestore.DocumentData,
 > implements firestore.QuerySnapshot<AppModelType, DbModelType>
 {
   private _materializedDocs: Array<
@@ -1201,7 +1202,7 @@ enum LimitType {
  */
 export class QueryOptions<
   AppModelType,
-  DbModelType extends firestore.DocumentData
+  DbModelType extends firestore.DocumentData,
 > {
   constructor(
     readonly parentPath: ResourcePath,
@@ -1235,7 +1236,7 @@ export class QueryOptions<
    */
   static forCollectionGroupQuery<
     AppModelType = firestore.DocumentData,
-    DbModelType extends firestore.DocumentData = firestore.DocumentData
+    DbModelType extends firestore.DocumentData = firestore.DocumentData,
   >(
     collectionId: string,
     converter = defaultConverter<AppModelType, DbModelType>()
@@ -1257,7 +1258,7 @@ export class QueryOptions<
    */
   static forCollectionQuery<
     AppModelType = firestore.DocumentData,
-    DbModelType extends firestore.DocumentData = firestore.DocumentData
+    DbModelType extends firestore.DocumentData = firestore.DocumentData,
   >(
     collectionRef: ResourcePath,
     converter = defaultConverter<AppModelType, DbModelType>()
@@ -1333,7 +1334,7 @@ export class QueryOptions<
 
   withConverter<
     NewAppModelType,
-    NewDbModelType extends firestore.DocumentData = firestore.DocumentData
+    NewDbModelType extends firestore.DocumentData = firestore.DocumentData,
   >(
     converter: firestore.FirestoreDataConverter<NewAppModelType, NewDbModelType>
   ): QueryOptions<NewAppModelType, NewDbModelType> {
@@ -1402,7 +1403,7 @@ export class QueryOptions<
  */
 export class Query<
   AppModelType = firestore.DocumentData,
-  DbModelType extends firestore.DocumentData = firestore.DocumentData
+  DbModelType extends firestore.DocumentData = firestore.DocumentData,
 > implements firestore.Query<AppModelType, DbModelType>
 {
   private readonly _serializer: Serializer;
@@ -2772,7 +2773,7 @@ export class Query<
   withConverter(converter: null): Query;
   withConverter<
     NewAppModelType,
-    NewDbModelType extends firestore.DocumentData = firestore.DocumentData
+    NewDbModelType extends firestore.DocumentData = firestore.DocumentData,
   >(
     converter: firestore.FirestoreDataConverter<NewAppModelType, NewDbModelType>
   ): Query<NewAppModelType, NewDbModelType>;
@@ -2828,7 +2829,7 @@ export class Query<
    */
   withConverter<
     NewAppModelType,
-    NewDbModelType extends firestore.DocumentData = firestore.DocumentData
+    NewDbModelType extends firestore.DocumentData = firestore.DocumentData,
   >(
     converter: firestore.FirestoreDataConverter<
       NewAppModelType,
@@ -2852,7 +2853,7 @@ export class Query<
  */
 export class CollectionReference<
     AppModelType = firestore.DocumentData,
-    DbModelType extends firestore.DocumentData = firestore.DocumentData
+    DbModelType extends firestore.DocumentData = firestore.DocumentData,
   >
   extends Query<AppModelType, DbModelType>
   implements firestore.CollectionReference<AppModelType, DbModelType>
@@ -3107,7 +3108,7 @@ export class CollectionReference<
   withConverter(converter: null): CollectionReference;
   withConverter<
     NewAppModelType,
-    NewDbModelType extends firestore.DocumentData = firestore.DocumentData
+    NewDbModelType extends firestore.DocumentData = firestore.DocumentData,
   >(
     converter: firestore.FirestoreDataConverter<NewAppModelType, NewDbModelType>
   ): CollectionReference<NewAppModelType, NewDbModelType>;
@@ -3164,7 +3165,7 @@ export class CollectionReference<
    */
   withConverter<
     NewAppModelType,
-    NewDbModelType extends firestore.DocumentData = firestore.DocumentData
+    NewDbModelType extends firestore.DocumentData = firestore.DocumentData,
   >(
     converter: firestore.FirestoreDataConverter<
       NewAppModelType,
@@ -3185,7 +3186,7 @@ export class CollectionReference<
 export class AggregateQuery<
   AggregateSpecType extends firestore.AggregateSpec,
   AppModelType = firestore.DocumentData,
-  DbModelType extends firestore.DocumentData = firestore.DocumentData
+  DbModelType extends firestore.DocumentData = firestore.DocumentData,
 > implements
     firestore.AggregateQuery<AggregateSpecType, AppModelType, DbModelType>
 {
@@ -3424,7 +3425,7 @@ export class AggregateQuery<
 export class AggregateQuerySnapshot<
   AggregateSpecType extends firestore.AggregateSpec,
   AppModelType = firestore.DocumentData,
-  DbModelType extends firestore.DocumentData = firestore.DocumentData
+  DbModelType extends firestore.DocumentData = firestore.DocumentData,
 > implements
     firestore.AggregateQuerySnapshot<
       AggregateSpecType,
@@ -3587,7 +3588,7 @@ export function validateQueryOperator(
  */
 export function validateDocumentReference<
   AppModelType,
-  DbModelType extends firestore.DocumentData
+  DbModelType extends firestore.DocumentData,
 >(
   arg: string | number,
   value: firestore.DocumentReference<AppModelType, DbModelType>

diff --git a/dev/src/transaction.ts b/dev/src/transaction.ts
@@ -113,7 +113,7 @@ export class Transaction implements firestore.Transaction {
   get<
     AppModelType,
     DbModelType extends firestore.DocumentData,
-    AggregateSpecType extends firestore.AggregateSpec
+    AggregateSpecType extends firestore.AggregateSpec,
   >(
     aggregateQuery: firestore.AggregateQuery<
       AggregateSpecType,
@@ -150,7 +150,7 @@ export class Transaction implements firestore.Transaction {
   get<
     AppModelType,
     DbModelType extends firestore.DocumentData,
-    AggregateSpecType extends firestore.AggregateSpec
+    AggregateSpecType extends firestore.AggregateSpec,
   >(
     refOrQuery:
       | firestore.DocumentReference<AppModelType, DbModelType>
@@ -584,7 +584,7 @@ export class Transaction implements firestore.Transaction {
  */
 export function parseGetAllArguments<
   AppModelType,
-  DbModelType extends firestore.DocumentData
+  DbModelType extends firestore.DocumentData,
 >(
   documentRefsOrReadOptions: Array<
     | firestore.DocumentReference<AppModelType, DbModelType>

diff --git a/dev/src/types.ts b/dev/src/types.ts
@@ -138,7 +138,7 @@ const defaultConverterObj: FirestoreDataConverter<DocumentData> = {
  */
 export function defaultConverter<
   AppModelType,
-  DbModelType extends DocumentData
+  DbModelType extends DocumentData,
 >(): FirestoreDataConverter<AppModelType, DbModelType> {
   return defaultConverterObj as FirestoreDataConverter<
     AppModelType,