fix: ReadOnly transaction do not need to commit not rollback. (#2007)

googleapis · Mar 6, 2024 · 6a220a6 · 6a220a6
1 parent 4ad7750
commit 6a220a6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/dev/src/transaction.ts b/dev/src/transaction.ts
@@ -509,7 +509,7 @@ export class Transaction implements firestore.Transaction {
    * @internal
    */
   async rollback(): Promise<void> {
-    if (!this._transactionId) {
+    if (!this._transactionId || this._readOnly) {
       return;
     }
 
@@ -605,7 +605,7 @@ export class Transaction implements firestore.Transaction {
         );
       }
       const result = await promise;
-      if (!this._readTime) {
+      if (!this._readOnly) {
         await this.commit();
       }
       return result;

diff --git a/dev/test/transaction.ts b/dev/test/transaction.ts
@@ -780,8 +780,7 @@ describe('transaction operations', () => {
         async (transaction, docRef) => {
           transaction.set(docRef, {foo: 'bar'});
         },
-        begin({readOnly: {}}),
-        rollback()
+        begin({readOnly: {}})
       )
     ).to.eventually.be.rejectedWith(
       'Firestore read-only transactions cannot execute writes.'
@@ -824,8 +823,7 @@ describe('transaction operations', () => {
       {readOnly: true},
       (transaction, docRef) => transaction.get(docRef),
       begin({readOnly: {}}),
-      getDocument(),
-      commit()
+      getDocument()
     );
   });