Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow an explicit MustExist precondition for update #1985

Merged
merged 14 commits into from
Jan 24, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jan 19, 2024

This addresses a bug reported against the .NET SDK (googleapis/google-cloud-dotnet#11361) but applies to all SDKs. The conformance test was updated accordingly in googleapis/conformance-tests#82 and googleapis/conformance-tests#84.

This PR was ported to the java-firestore sdk in googleapis/java-firestore#1542.

Googlers see b/321064909 for more information.

@dconeybe dconeybe self-assigned this Jan 19, 2024
Copy link

conventional-commit-lint-gcf bot commented Jan 19, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jan 19, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 19, 2024
@dconeybe dconeybe changed the base branch from main to dconeybe/ConformanceTestUpdateTo3264aa6 January 19, 2024 19:37
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jan 20, 2024
@dconeybe dconeybe marked this pull request as ready for review January 22, 2024 15:26
@dconeybe dconeybe requested review from a team as code owners January 22, 2024 15:26
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jan 22, 2024
Base automatically changed from dconeybe/ConformanceTestUpdateTo3264aa6 to main January 22, 2024 16:44
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit 99d60a6 into main Jan 24, 2024
18 checks passed
@dconeybe dconeybe deleted the dconeybe/UpdateChangeToAllowExistsPrecondition branch January 24, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants