fix: Allow an explicit MustExist precondition for update #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: s
…wExistsPrecondition
product-auto-label
bot
added
size: m
dconeybe
changed the base branch from
main
to
dconeybe/ConformanceTestUpdateTo3264aa6
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: m
Base automatically changed from
dconeybe/ConformanceTestUpdateTo3264aa6
to
main
January 22, 2024 16:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug reported against the .NET SDK (googleapis/google-cloud-dotnet#11361) but applies to all SDKs. The conformance test was updated accordingly in googleapis/conformance-tests#82 and googleapis/conformance-tests#84.
This PR was ported to the java-firestore sdk in googleapis/java-firestore#1542.
Googlers see b/321064909 for more information.