Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't allow serialization of firestore settings #1742

Merged
merged 3 commits into from
Aug 8, 2022
Merged

fix: Don't allow serialization of firestore settings #1742

merged 3 commits into from
Aug 8, 2022

Commits on Aug 4, 2022

  1. Dont allow serialization of firestore settings 

    When logging any firestore object like WriteBatch,Transaction,etc the settings object also gets logged / exposed
This can be seen by running JSON.stringify on any firestore object even a document reference
Many developers log firestore objects to help them debug testing/prod issues, this leaking of entire firestore key via this._settings is a bad practice as per me
We can also use Object.defineProperty to make it non-enumerable or any other technique that you like
    @abhishekwebcode @ehsannas
    abhishekwebcode authored and ehsannas committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    0732380 View commit details
    Browse the repository at this point in the history

  2. Fix formatting.

    @ehsannas
    ehsannas committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    3e74d1d View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Only redact credentials.

    @ehsannas
    ehsannas committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    b93cae3 View commit details
    Browse the repository at this point in the history