Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency protobufjs to v7 #1747

Merged

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jul 9, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
protobufjs ^6.8.6 -> ^7.0.0 age adoption passing confidence

Release Notes

protobufjs/protobuf.js

v7.0.0

Compare Source

⚠ BREAKING CHANGES
  • drop support for Node 4, 6, 8, 10 (#​1764)
  • move command line tool to a new package named protobufjs-cli (#​1234)
  • encoding of empty Buffers (#​1514)
Features
Bug Fixes
6.10.2 (2020-11-13)
Bug Fixes
6.10.1 (2020-07-16)
Bug Fixes

Configuration

📅 Schedule: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from a team as code owners July 9, 2022 09:55
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 9, 2022
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jul 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2022
@dconeybe
Copy link
Contributor

dconeybe commented Jul 9, 2022

Note: A customer has requested this upgrade to fix a security issue: #1740

@alexander-fenster alexander-fenster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 10, 2022
@alexander-fenster
Copy link
Contributor

Please do not merge this one just yet. I'm preparing a release of google-gax that would pull protobufjs v7, then we'll merge both dependency updates together; otherwise, it will pull two versions of protobufjs (v6 and v7) which will increase the distribution size and load time.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 21, 2022
@alexander-fenster alexander-fenster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2022
@alexander-fenster
Copy link
Contributor

It's OK to merge now. I added a dependency on protobufjs-cli to make sure the update.sh script keeps working.

@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label Jul 21, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4e8d33c into googleapis:main Jul 22, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants