Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the v1beta1 export lazy loaded #196

Closed
wants to merge 1 commit into from

Conversation

inlined
Copy link

@inlined inlined commented May 18, 2018

Fixes issue where loading Firestore force-loads google-gax. This adds several hundred ms latency on Cloud Functions when all we want to do is expose a native Firestore Document type from JSON.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • [N/A] Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2018
@schmidt-sebastian
Copy link
Contributor

@inlined Thanks for sending this over! This was merged as part of #197, which also removed the dependency on '@google-cloud/common-grpc`. With these two changes, loading the Firestore module now only takes tens of milliseconds instead of hundreds. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants