Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Datastore mode #552

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

This adds a section to the Readme advising that this client can't be used with Firestore instances in Datastore mode.

Fixes #459

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2019
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #552 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files          24       24           
  Lines        1943     1943           
  Branches      161      161           
=======================================
  Hits         1864     1864           
  Misses         57       57           
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f960ca...975df9a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #552 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files          24       24           
  Lines        1943     1943           
  Branches      161      161           
=======================================
  Hits         1864     1864           
  Misses         57       57           
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f960ca...975df9a. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 6b5bd1e into master Feb 22, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-datastoremode branch March 11, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants