Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

test: fix failing tests due to leaks #163

Merged
merged 1 commit into from
Nov 16, 2018
Merged

test: fix failing tests due to leaks #163

merged 1 commit into from
Nov 16, 2018

Conversation

JustinBeckwith
Copy link
Contributor

I don't feel entirely great about the way I had to pollute the sample to make this actually work. Here's a TL;DR of what was happening:

  • The same samples a local file with a list of alert policies
  • The the tests add a bunch of things
  • The sample restores the list of previous policies

This works great until you run the test twice at the same time :) We start creating a bunch of policies that leak from session to session, and eventually fill up.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2018
@codecov
Copy link

codecov bot commented Nov 16, 2018

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #163   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0280741...621ffe3. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants