This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
refactor: modernize and fix the sample tests #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crwilcox
approved these changes
Dec 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the monitoring sample tests have been flaky for as long as I can remember. In the process of upgrading to mocha/chai/execa, I added retries in a few places, and moved a few things to serial execution to discover what looks to be a few underlying issues with the API. The result of the investigation was these bugs:
I suspect all of these are related to the underlying API, but it's worth ruling out the client library as well. Adding @alexander-fenster since he helped with some of the investigation here too :)
@theacodes - these are bad enough that I think someone needs to take point on reaching out to the monitoring team, and figuring out what's going on. Since I'm "out of office", do you mind reaching out?