Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs samples): update missing argv in sample metadata of push subscription #1946

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

telosma
Copy link
Contributor

@telosma telosma commented Jun 20, 2024

What

Sample metadata usage for creating a push subscription is missing the push endpoint

Screenshot 2024-06-20 at 13 04 40

@telosma telosma requested review from a team as code owners June 20, 2024 06:16
Copy link

google-cla bot commented Jun 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. labels Jun 20, 2024
Copy link

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 20, 2024
@feywind
Copy link
Collaborator

feywind commented Jun 20, 2024

Those linter issues aren't a problem with this PR.

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 20, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2024
@feywind feywind added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 27, 2024
@feywind
Copy link
Collaborator

feywind commented Jun 27, 2024

Sorry for the delay, we had some CI hiccups.

@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2024
@feywind feywind merged commit 34b8c03 into googleapis:main Jun 27, 2024
15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants