Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs samples): update missing argv in sample metadata of push subscription #1946

Merged
merged 3 commits into from
Jun 27, 2024
Merged

fix(docs samples): update missing argv in sample metadata of push subscription #1946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76caf5c
fix(docs samples): update missing argv in sample metadata for push su…
telosma Jun 20, 2024
5727531
Merge branch 'main' into fix-docs-sample-metadata
feywind Jun 20, 2024
a688578
Merge branch 'main' into fix-docs-sample-metadata
telosma Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ View the [source code](https://github.com/googleapis/nodejs-pubsub/blob/main/sam
__Usage:__


`node createPushSubscription.js <topic-name-or-id> <subscription-name-or-id>`
`node createPushSubscription.js <endpoint-url> <topic-name-or-id> <subscription-name-or-id>`


-----
Expand All @@ -226,7 +226,7 @@ View the [source code](https://github.com/googleapis/nodejs-pubsub/blob/main/sam
__Usage:__


`node createPushSubscriptionNoWrapper.js <topic-name-or-id> <subscription-name-or-id>`
`node createPushSubscriptionNoWrapper.js <endpoint-url> <topic-name-or-id> <subscription-name-or-id>`


-----
Expand Down
2 changes: 1 addition & 1 deletion samples/createPushSubscription.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
// sample-metadata:
// title: Create Push Subscription
// description: Creates a new push subscription.
// usage: node createPushSubscription.js <topic-name-or-id> <subscription-name-or-id>
// usage: node createPushSubscription.js <endpoint-url> <topic-name-or-id> <subscription-name-or-id>

// [START pubsub_create_push_subscription]
/**
Expand Down
2 changes: 1 addition & 1 deletion samples/createPushSubscriptionNoWrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
// sample-metadata:
// title: Create Push Subscription With No Wrapper
// description: Creates a new push subscription, but disables wrapping for payloads.
// usage: node createPushSubscriptionNoWrapper.js <topic-name-or-id> <subscription-name-or-id>
// usage: node createPushSubscriptionNoWrapper.js <endpoint-url> <topic-name-or-id> <subscription-name-or-id>

// [START pubsub_create_unwrapped_push_subscription]
/**
Expand Down
2 changes: 1 addition & 1 deletion samples/typescript/createPushSubscription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// sample-metadata:
// title: Create Push Subscription
// description: Creates a new push subscription.
// usage: node createPushSubscription.js <topic-name-or-id> <subscription-name-or-id>
// usage: node createPushSubscription.js <endpoint-url> <topic-name-or-id> <subscription-name-or-id>

// [START pubsub_create_push_subscription]
/**
Expand Down
2 changes: 1 addition & 1 deletion samples/typescript/createPushSubscriptionNoWrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// sample-metadata:
// title: Create Push Subscription With No Wrapper
// description: Creates a new push subscription, but disables wrapping for payloads.
// usage: node createPushSubscriptionNoWrapper.js <topic-name-or-id> <subscription-name-or-id>
// usage: node createPushSubscriptionNoWrapper.js <endpoint-url> <topic-name-or-id> <subscription-name-or-id>

// [START pubsub_create_unwrapped_push_subscription]
/**
Expand Down
Loading