Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unflake the system tests #483

Closed
JustinBeckwith opened this issue Feb 15, 2019 · 2 comments
Closed

Unflake the system tests #483

JustinBeckwith opened this issue Feb 15, 2019 · 2 comments
Assignees
@callmehiphop
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@JustinBeckwith
Copy link
Contributor

The system tests are currently hella flaky.
@JustinBeckwith JustinBeckwith added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 15, 2019
@callmehiphop callmehiphop mentioned this issue Feb 16, 2019
Merged
3 tasks
@callmehiphop
Copy link
Contributor

@kir-titievsky I've been noticing lately that sometimes when I fetch a list of snapshots, I get more than I am expecting. In my testing I create a branch new topic/subscription, so I would assume that there would be no pre-existing snapshots. After creating 1, if I list the snapshots I'm often surprised to see that there might be 2 or 3. Any ideas why this might be happening?

@callmehiphop
Copy link
Contributor

Nevermind! I forgot Snapshots were global to the project, so now that we run system-tests multiple times per PR, I think what I'm seeing makes sense.

@google-cloud-label-sync google-cloud-label-sync bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jan 31, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@callmehiphop callmehiphop

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JustinBeckwith @callmehiphop @yoshi-automation