Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore messages that come in after close #485

Merged
merged 7 commits into from
Feb 18, 2019
Merged

fix: ignore messages that come in after close #485

merged 7 commits into from
Feb 18, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Feb 16, 2019

Fixes #483

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 16, 2019
@callmehiphop callmehiphop added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 16, 2019
@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #485 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          15       15           
  Lines         982      982           
  Branches       73       73           
=======================================
  Hits          934      934           
  Misses         43       43           
  Partials        5        5
Impacted Files Coverage Δ
src/lease-manager.ts 100% <100%> (ø) ⬆️
src/subscriber.ts 96.84% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ea4b4...4566189. Read the comment docs.

@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2019
@callmehiphop callmehiphop removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 17, 2019
@JustinBeckwith JustinBeckwith merged commit e59f8ec into googleapis:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants