Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid typings #507

Closed
merlinnot opened this issue Feb 28, 2019 · 2 comments
Closed

Invalid typings #507

merlinnot opened this issue Feb 28, 2019 · 2 comments
Assignees
@callmehiphop
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@merlinnot
Copy link
Contributor

Environment details

  • OS: irrelevant
  • Node.js version: irrelevant
  • npm version: irrelevant
  • @google-cloud/pubsub version: 0.26.0

It looks like the typings shipped with 0.26.0 are incorrect. I can't see any difference in actual implementation nor the changelog that would explain these changes:

  • Topic.exists has a required parameter - a callback. It should return void if provided with a callback, a promise otherwise.
  • Topic.get returns a Topic, not [Topic] as it used to. Although I'd gladly welcome this change to the interface, it seems that it actually didn't change and still returns an array.

There might be more, I just pointed out the ones I've came across and tested.
@callmehiphop callmehiphop added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 28, 2019
@callmehiphop callmehiphop self-assigned this Feb 28, 2019
@JustinBeckwith JustinBeckwith added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Mar 1, 2019
@callmehiphop callmehiphop mentioned this issue Mar 2, 2019
Merged
3 tasks
@merlinnot
Copy link
Contributor Author

@callmehiphop could you please reopen? Still invalid in v0.27.0

I'll make a PR to fix it, at least the parts that I use. I don't have time to go through all of the types myself.

@merlinnot merlinnot mentioned this issue Mar 5, 2019
Merged
3 tasks
@callmehiphop callmehiphop reopened this Mar 5, 2019
@callmehiphop
Copy link
Contributor

Sure thing, sorry about that @merlinnot, I'll make another pass through today.

@callmehiphop callmehiphop mentioned this issue Mar 6, 2019
Merged
3 tasks
@google-cloud-label-sync google-cloud-label-sync bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jan 31, 2020
feywind pushed a commit to feywind/nodejs-pubsub that referenced this issue Nov 12, 2024
@stephenplusplus
fix: cancel streaming grpc request when user ends stream (googleapis#507
2b4297c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@callmehiphop callmehiphop

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JustinBeckwith @callmehiphop @merlinnot