-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ackDeadline editable #6
Comments
Agree on this. We have long-running processes that we dynamically refresh the ackDeadline on a timer based on a rolling average of job completion, and we lost this capability on this version. |
I also have long-running jobs, and the current approach will start with an const sub = client.subscription(name);
sub.ackDeadline = 5 * 60 * 1000;
sub.histogram = {
add: () => { },
percentile: () => sub.ackDeadline
}; One can further monkey patch the subscription's |
We should have a release coming up in the next several days that will include the ability to manually set ack deadlines. const subscription = topic.subscription('my-sub', {ackDeadline: 20}); // 20 seconds |
This is a request originally from @mkamioner in this PR.
The text was updated successfully, but these errors were encountered: