-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: refactor(subscriber): remove unneeded code & utilize typescript #388
BREAKING CHANGE: refactor(subscriber): remove unneeded code & utilize typescript #388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, but I don't have a great feel for the logic of the stuff you're replacing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I really like the new hierarchy 👍
} | ||
|
||
this._acks.add(message); | ||
await this._acks.onFlush(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
👋 @callmehiphop I'm super excited for this to land :) |
@JustinBeckwith @stephenplusplus finished tests and did a few refactors here and there, but I think we're good to go! |
LGTM :) If @stephenplusplus is cool, I'm cool. |
this._onEnd(stream, status); | ||
} else { | ||
stream.once('end', () => this._onEnd(stream, status)); | ||
stream.push(null); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/message-stream.ts
Outdated
* @param {stream} stream Duplexify stream. | ||
*/ | ||
private _interceptGrpcStream(stream: GaxDuplex): void { | ||
const setReadable = stream.setReadable; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I went ahead and made a couple perf updates. I think the one worth mentioning is the decision to bypass gax streams and use the grpc stream directly. With |
* build: add Kokoro configs for autorelease * build: add Kokoro configs for autorelease * chore: remove CircleCI config
Fixes #6
Fixes #12
Fixes #115
Fixes #119
Breaking change ahead!
There's been a small restructuring made to the subscription options.
Before:
After