feat: explicitly pull in grpc-js ~1.0.5 #1030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than gax, and pin it at ~1.0.5 to get a fix for the stream write after end
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1030 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 22 22
Lines 10709 10709
Branches 468 511 +43
=======================================
Hits 10206 10206
Misses 500 500
Partials 3 3 Continue to review full report at Codecov.
|
|
I don't feel too positive or too negative about that - there are pros and cons :) |
|
After talking it over internally, I think I'm going to pause this and just put in a gax PR, and repurpose this one for pulling in the new gax. |
|
Gax versions were updated by #1085 so I'm going to go ahead and close this. |
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
🤖 I have created a release *beep* *boop* --- ### [3.9.4](googleapis/nodejs-bigtable@v3.9.3...v3.9.4) (2022-03-16) ### Bug Fixes * do not cancel stream after server returned ok or cancelled status ([googleapis#1029](googleapis/nodejs-bigtable#1029)) ([33754a2](googleapis/nodejs-bigtable@33754a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a direct dependency to grpc-js so we can pull in versions faster than gax, if needed. This is also correct (imo) because the Pub/Sub library is already directly referencing things in grpc-js.
Also bump us to ~1.0.5 so we get the fix for the stream write after end. Hopefully fixes #825.