Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(main): release 2.18.5 #1467

Merged
merged 1 commit into from
Jan 25, 2022
Merged

chore(main): release 2.18.5 #1467

merged 1 commit into from
Jan 25, 2022

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Jan 20, 2022 •
edited
Loading

🤖 I have created a release beep boop

2.18.5 (2022-01-21)

Bug Fixes

  • deps: update dependency @opentelemetry/semantic-conventions to v1 (#1407) (740d78c)
  • deps: update dependency google-gax to v2.29.0 (#1452) (f419137)
  • deps: update dependency google-gax to v2.29.4 (#1469) (8abbfa7)
  • update to work with latest node types (changed the return type of Stream.destroy()) (#1464) (fddc2e7)

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested review from a team as code owners January 20, 2022 19:45
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 20, 2022
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jan 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 20, 2022
@feywind feywind added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 20, 2022
@release-please release-please bot force-pushed the release-please--branches--main branch from 2f04327 to 9a8e8ec Compare January 20, 2022 21:14
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 20, 2022
@release-please release-please bot force-pushed the release-please--branches--main branch from 9a8e8ec to 62e0335 Compare January 21, 2022 10:48
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2022
@release-please release-please bot force-pushed the release-please--branches--main branch from 62e0335 to af5487e Compare January 21, 2022 23:25
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2022
@feywind feywind removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 21, 2022
feywind
feywind approved these changes Jan 21, 2022
View reviewed changes
Copy link
Collaborator

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - hopefully this doesn't actually make a release until Monday...

@Ranguna
Copy link

Ranguna commented Jan 25, 2022

@feywind Looks like it indeed was not released before Monday :P

Is the release pending because of the ci/kokoro: Samples test step failing ?

I'm patiently waiting for this release so I can upgrade my node types version.

@feywind
Copy link
Collaborator

feywind commented Jan 25, 2022

@Ranguna It looks like there's a timing flakiness in one of the schema tests. I think there's an open issue to go back and make this more reliable, but for now I'll just massage it until it goes through.

  1) schema
       should listen for protobuf messages:
     Error: 5 NOT_FOUND: The schema associated with the topic has been deleted.

@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2022
@feywind feywind added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jan 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit a8e1fd0 into main Jan 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the release-please--branches--main branch January 25, 2022 21:56
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jan 25, 2022
@Ranguna
Copy link

Ranguna commented Jan 25, 2022

Ah yes, there's at least one test that throws a fit every once in a while in all projects I've seen 😋

Thanks for taking a look at this one and big thank you to the whole team!

@release-please
Copy link
Contributor Author

🤖 Release is at https://github.com/googleapis/nodejs-pubsub/releases/tag/v2.18.5 🌻

@release-tool-publish-reporter
Copy link

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter
Copy link

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feywind feywind feywind approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. autorelease: published
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ranguna @feywind @yoshi-kokoro