-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix flaky schema and subscription tests #1518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
Pull request size is large.
api: pubsub
Issues related to the googleapis/nodejs-pubsub API.
labels
Apr 13, 2022
feywind
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 13, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 13, 2022
feywind
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 13, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Apr 13, 2022
feywind
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 13, 2022
I'm going to run this through CI a few more times just to make sure it's not flaking now... |
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 13, 2022
feywind
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 13, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 13, 2022
feywind
changed the title
tests: fix flaky schema and subscription tests
fix: fix flaky schema and subscription tests
Apr 13, 2022
I'm editing the type to |
Mentioned in chat, but repeating here: if anyone reviews this and there aren't major issues, please go ahead and merge as well. |
alexander-fenster
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fixes:
#1498
#1516
#1468
#1327