Update google-gax and add Synth.py #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Jun 27, 2018
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 887 888 +1
=====================================
+ Hits 887 888 +1
Continue to review full report at Codecov.
|
stephenplusplus
pushed a commit
to stephenplusplus/nodejs-pubsub
that referenced
this pull request
Aug 31, 2018
…properly (googleapis#158) * build: rename build.sh => test.sh; presubmit jobs runs lint and docs properly * build: use node8 for lint and docs job * trigger re-build
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
Fixes googleapis#85 - [x] Tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) --- This PR should be ready to go. I believe this requires a major semver bump. I figured the test files shouldn't be updated in the same PR. The only thing that really needs to be pointed out is that classes shouldn't be instantiatable without the new keyword: ```js const client1 = new Bigtable() const client2 = Bigtable() // Error: Class constructor Foo cannot be invoked without 'new' ``` I was on the fence about requiring people to use the `new` keyword or not, and chose to make it optional. I did this by using a proxy: ```js Bigtable = new Proxy(Bigtable, { apply(target, thisArg, argumentsList) { return new target(...argumentsList); }, }); ``` Let me know if this should be removed. I didn't add that to the semi-private classes since the common case of creating one is something like `instance.table(...)` and not `new Table(...)` Note - This was removed in review As before, most of this was done via lebab so there may be some issues so please do go through it again to make sure nothing terrible is being done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151