Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 179: Adds missing return statement in docs #180

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

nareddyt
Copy link
Contributor

Fixes #179

Added a missing return statement. This change should propagate to the auto-generated docs page.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2018
@codecov
Copy link

codecov bot commented Jul 12, 2018

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #180   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         888    888           
=====================================
  Hits          888    888
Impacted Files Coverage Δ
src/topic.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c400db2...780dfa0. Read the comment docs.

@stephenplusplus stephenplusplus merged commit 388f532 into googleapis:master Jul 13, 2018
@stephenplusplus
Copy link
Contributor

Thanks!

feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
* Remove .js extension in require calls

* Use arrow functions and remove self

* Remove create-error-class and string-format-obj

* Reverting uses of self. in instance.js

* Fixing reference to options in table.js mutate

* r/self/this in instance.js

* Address PR comments

* Add name to other errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants