Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update for linter failures #1947

Merged
merged 10 commits into from
Jun 26, 2024
Merged

chore: update for linter failures #1947

merged 10 commits into from
Jun 26, 2024

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Jun 20, 2024

Just opening a separate PR for this, to keep it clean.

@product-auto-label product-auto-label bot added size: u Pull request is empty. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Jun 20, 2024
@feywind feywind requested review from a team as code owners June 20, 2024 21:31
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: u Pull request is empty. labels Jun 20, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 20, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 21, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 21, 2024
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 21, 2024
@feywind feywind added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 21, 2024
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 26, 2024
@feywind feywind removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 26, 2024
@feywind feywind added the automerge Merge the pull request once unit tests and other checks pass. label Jun 26, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0bffecc into googleapis:main Jun 26, 2024
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 26, 2024
@feywind feywind deleted the linter-fixes-2 branch June 27, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feywind @sofisl