Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use split common modules #200

Merged
merged 3 commits into from
Aug 6, 2018
Merged

chore: use split common modules #200

merged 3 commits into from
Aug 6, 2018

Conversation

JustinBeckwith
Copy link
Contributor

Next step is to remove common

@JustinBeckwith JustinBeckwith requested a review from a team August 6, 2018 04:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2018
@ghost ghost assigned JustinBeckwith Aug 6, 2018
@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         892    900    +8     
=====================================
+ Hits          892    900    +8
Impacted Files Coverage Δ
src/subscription.js 100% <100%> (ø) ⬆️
src/topic.js 100% <100%> (ø) ⬆️
src/iam.js 100% <100%> (ø) ⬆️
src/subscriber.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️
src/connection-pool.js 100% <100%> (ø) ⬆️
src/snapshot.js 100% <100%> (ø) ⬆️
src/publisher.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5315aad...4f75677. Read the comment docs.

@ghost ghost assigned stephenplusplus Aug 6, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 6, 2018
@JustinBeckwith JustinBeckwith added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 6, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@JustinBeckwith JustinBeckwith merged commit f0d1594 into googleapis:master Aug 6, 2018
@JustinBeckwith JustinBeckwith deleted the projectify branch November 12, 2018 22:46
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants