Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use let and const #204

Merged
merged 3 commits into from
Aug 9, 2018
Merged

chore: use let and const #204

merged 3 commits into from
Aug 9, 2018

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@JustinBeckwith JustinBeckwith requested review from callmehiphop and a team August 7, 2018 02:19
@ghost ghost assigned JustinBeckwith Aug 7, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2018
function createConnection() {
self.createConnection();
self.queue.splice(self.queue.indexOf(timeoutHandle), 1);
setImmediate(() => {

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@codecov
Copy link

codecov bot commented Aug 7, 2018

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #204   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         900    901    +1     
=====================================
+ Hits          900    901    +1
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️
src/histogram.js 100% <100%> (ø) ⬆️
src/topic.js 100% <100%> (ø) ⬆️
src/subscription.js 100% <100%> (ø) ⬆️
src/subscriber.js 100% <100%> (ø) ⬆️
src/publisher.js 100% <100%> (ø) ⬆️
src/connection-pool.js 100% <100%> (ø) ⬆️
src/snapshot.js 100% <100%> (ø) ⬆️
src/iam.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e7480...51baf96. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit e7221e7 into googleapis:master Aug 9, 2018
@JustinBeckwith JustinBeckwith deleted the novar branch November 12, 2018 22:46
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
* Add renovate.json

* update renovate.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants