Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add subscription expiration policy docs #400

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Dec 8, 2018

This was a new feature added to the API - however since we have a separate set of docs for the manual layer of this library, we would often miss changes to the request configs. We need a way to not have to maintain two separate sets of config objects.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 8, 2018
@jkwlui jkwlui self-assigned this Dec 8, 2018
Copy link
Contributor

@callmehiphop callmehiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also pass this in via subscription.setMetadata() as well!

@jkwlui jkwlui merged commit ef2328b into master Dec 10, 2018
@jkwlui jkwlui deleted the add-subscription-expiration-policy-doc branch December 10, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants