Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(topic): create method for publishing json #430

Merged
merged 2 commits into from
Jan 16, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 61 additions & 1 deletion src/topic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,66 @@ export class Topic {
publish(data: Buffer, attributes?, callback?): Promise<string>|void {
return this.publisher.publish(data, attributes, callback);
}
/**
* Publish the provided JSON. It should be noted that all messages published
* are done so in the form of a Buffer. This is simply a convenience method
* that will transform JSON into a Buffer before publishing.
* {@link Subscription} objects will always return message data in the form of
* a Buffer, so any JSON published will require manual deserialization.
*
* @see Topic#publish
*
* @throws {Error} If non-object data is provided.
*
* @param {object} json The JSON data to publish.
* @param {object} [attributes] Attributes for this message.
* @param {PublishCallback} [callback] Callback function.
* @returns {Promise<PublishResponse>}
*
* @example
* const {PubSub} = require('@google-cloud/pubsub');
* const pubsub = new PubSub();
* const topic = pubsub.topic('my-topic');
*
* const data = {
* foo: 'bar'
* };
*
* const callback = (err, messageId) => {
* if (err) {
* // Error handling omitted.
* }
* };
*
* topic.publishJSON(data, callback);
*
* //-
* // Optionally you can provide an object containing attributes for the
* // message. Note that all values in the object must be strings.
* //-
* const attributes = {
* key: 'value'
* };
*
* topic.publishJSON(data, attributes, callback);
*
* //-
* // If the callback is omitted, we'll return a Promise.
* //-
* topic.publishJSON(data).then((messageId) => {});
*/
publishJSON(json: object, attributes?: object): Promise<string>;
publishJSON(json: object, callback: PublishCallback): void;
publishJSON(json: object, attributes: object, callback: PublishCallback):
void;
publishJSON(json: object, attributes?, callback?): Promise<string>|void {
if (!is.object(json)) {
throw new Error('First parameter should be an object.');
}

const data = Buffer.from(JSON.stringify(json));
return this.publish(data, attributes, callback);
}
/**
* Set the publisher options.
*
Expand Down Expand Up @@ -649,7 +709,7 @@ paginator.extend(Topic, ['getSubscriptions']);
* that a callback is omitted.
*/
promisifyAll(Topic, {
exclude: ['publish', 'setPublishOptions', 'subscription'],
exclude: ['publish', 'publishJSON', 'setPublishOptions', 'subscription'],
});

export {PublishOptions};
34 changes: 33 additions & 1 deletion test/topic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ const fakePromisify = Object.assign({}, pfy, {
}
promisified = true;
assert.deepStrictEqual(
options.exclude, ['publish', 'setPublishOptions', 'subscription']);
options.exclude,
['publish', 'publishJSON', 'setPublishOptions', 'subscription']);
},
});

Expand Down Expand Up @@ -553,6 +554,37 @@ describe('Topic', () => {
});
});

describe('publishJSON', () => {
it('should throw an error for non-object types', () => {
const expectedError = new Error('First parameter should be an object.');

assert.throws(() => topic.publishJSON('hi'), expectedError);
});

it('should transform JSON into a Buffer', () => {
const stub = sandbox.stub(topic, 'publish');
const json = {foo: 'bar'};
const expectedBuffer = Buffer.from(JSON.stringify(json));

topic.publishJSON(json);

const [buffer] = stub.lastCall.args;
assert.deepStrictEqual(buffer, expectedBuffer);
});

it('should pass along the attributes and callback', () => {
const stub = sandbox.stub(topic, 'publish');
const fakeAttributes = {};
const fakeCallback = () => {};

topic.publishJSON({}, fakeAttributes, fakeCallback);

const [, attributes, callback] = stub.lastCall.args;
assert.strictEqual(attributes, fakeAttributes);
assert.strictEqual(callback, fakeCallback);
});
});

describe('setPublishOptions', () => {
it('should call through to Publisher#setOptions', () => {
const fakeOptions = {};
Expand Down