fix(sample): fix retry codes in retry sample code #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
callmehiphop
approved these changes
Feb 1, 2019
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes retry codes in sample code.
These were updated in #419, but it looks like both the previous and the updated values are wrong, gax expects retry codes as numbers.
The documentation for gax-nodejs also looks flawed (http://googleapis.github.io/gax-nodejs/global.html#RetryOptions), I've opened a PR to update the docs there to.
It takes a bit of time to figure out how to actually set up custom retry for pubsub, it would be a bit easier if the sample codes are updated.