Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make mention of message change in changelog #469

Merged
merged 2 commits into from
Feb 7, 2019
Merged

docs: make mention of message change in changelog #469

merged 2 commits into from
Feb 7, 2019

Conversation

callmehiphop
Copy link
Contributor

Fixes #465

Will add to the official release notes after approved.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 7, 2019
JustinBeckwith
JustinBeckwith approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also go back and add this to the release notes in the github release?

@callmehiphop callmehiphop merged commit bd85121 into googleapis:master Feb 7, 2019
@callmehiphop callmehiphop deleted the dg--465 branch February 7, 2019 21:41
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@yoshi-automation @callmehiphop
build: only pipe to codecov if tests run in Node 10 (googleapis#469)
ec827f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@callmehiphop @JustinBeckwith @googlebot