Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(message): use precise-date for message publish time #503

Merged
merged 6 commits into from
Feb 28, 2019
Merged

feat(message): use precise-date for message publish time #503

merged 6 commits into from
Feb 28, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Feb 27, 2019

publishTime is returned with microsecond precision, seems like a great use case for precise date!

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 27, 2019
src/subscriber.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #503 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   94.83%   94.91%   +0.08%     
==========================================
  Files          15       15              
  Lines         987      984       -3     
  Branches       83       83              
==========================================
- Hits          936      934       -2     
+ Misses         43       42       -1     
  Partials        8        8
Impacted Files Coverage Δ
src/subscriber.ts 97.82% <100%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663523d...5d1bee7. Read the comment docs.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this a breaking change?

@callmehiphop
Copy link
Contributor Author

@JustinBeckwith technically yes, but I don't expect it to impact anyone. (famous last words)

@JustinBeckwith JustinBeckwith merged commit d162958 into googleapis:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants