-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(subscription): support push config auth methods #504
Conversation
d589802
to
e85a106
Compare
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 15 15
Lines 987 987
Branches 83 83
=======================================
Hits 936 936
Misses 43 43
Partials 8 8
Continue to review full report at Codecov.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
@JustinBeckwith could you fight the CLA bot for me? This pulled in a new push config option so I had to regenerate the proto types and reference the correct interface. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
This PR was generated using Autosynth. 🌈
Here's the log from Synthtool: