Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ts): fix getPolicy promise return signature #511

Merged
merged 2 commits into from
Mar 1, 2019
Merged

fix(ts): fix getPolicy promise return signature #511

merged 2 commits into from
Mar 1, 2019

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Mar 1, 2019

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2019
@JustinBeckwith JustinBeckwith changed the title fix getPolicy promise return signature fix(ts): fix getPolicy promise return signature Mar 1, 2019
@codecov
Copy link

codecov bot commented Mar 1, 2019 •
edited
Loading

Codecov Report

Merging #511 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #511   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          15       15           
  Lines         984      984           
  Branches       83       83           
=======================================
  Hits          934      934           
  Misses         42       42           
  Partials        8        8
Impacted Files Coverage Δ
src/iam.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 613c26d...55024c2. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 60489bf into googleapis:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AVaksman @JustinBeckwith @googlebot