Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): export all the types #516

Merged
merged 2 commits into from
Mar 2, 2019
Merged

fix(typescript): export all the types #516

merged 2 commits into from
Mar 2, 2019

Conversation

callmehiphop
Copy link
Contributor

Updating the src structure to mirror what we have going on in Storage while exporting all the things!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2019
@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #516 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage   94.95%   94.97%   +0.02%     
==========================================
  Files          15       16       +1     
  Lines         991      996       +5     
  Branches       87       87              
==========================================
+ Hits          941      946       +5     
  Misses         42       42              
  Partials        8        8
Impacted Files Coverage Δ
src/iam.ts 100% <ø> (ø) ⬆️
src/snapshot.ts 100% <ø> (ø) ⬆️
src/publisher.ts 100% <ø> (ø) ⬆️
src/topic.ts 91.66% <ø> (ø) ⬆️
src/subscription.ts 100% <ø> (ø) ⬆️
src/index.ts 100% <100%> (ø) ⬆️
src/pubsub.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d9c13d...af514cd. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit c0f3147 into googleapis:master Mar 2, 2019
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants