-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bucket.upload doesn't retry failed resumable requests #1133
Labels
api: storage
Issues related to the googleapis/nodejs-storage API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
product-auto-label
bot
added
the
api: storage
Issues related to the googleapis/nodejs-storage API.
label
Mar 27, 2020
bcoe
added
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
priority: p2
Moderately-important priority. Fix may not be included in next release.
labels
Mar 27, 2020
Looking at this again - a simple fix would be only to set @bcoe is this a acceptable solution - happy to do a PR if it is? |
rhodgkins
added a commit
to bookcreator/nodejs-storage
that referenced
this issue
Mar 28, 2020
rhodgkins
added a commit
to bookcreator/nodejs-storage
that referenced
this issue
Mar 28, 2020
4 tasks
rhodgkins
added a commit
to bookcreator/nodejs-storage
that referenced
this issue
Mar 28, 2020
rhodgkins
added a commit
to bookcreator/nodejs-storage
that referenced
this issue
Mar 28, 2020
…specting the file size (fixes googleapis#1133)
rhodgkins
added a commit
to bookcreator/nodejs-storage
that referenced
this issue
Apr 23, 2020
rhodgkins
added a commit
to bookcreator/nodejs-storage
that referenced
this issue
Apr 23, 2020
rhodgkins
added a commit
to bookcreator/nodejs-storage
that referenced
this issue
Apr 23, 2020
…specting the file size (fixes googleapis#1133)
rhodgkins
added a commit
to bookcreator/nodejs-storage
that referenced
this issue
Apr 29, 2020
rhodgkins
added a commit
to bookcreator/nodejs-storage
that referenced
this issue
Apr 29, 2020
…specting the file size (fixes googleapis#1133)
rhodgkins
added a commit
to bookcreator/nodejs-storage
that referenced
this issue
Apr 30, 2020
rhodgkins
added a commit
to bookcreator/nodejs-storage
that referenced
this issue
Apr 30, 2020
…specting the file size (fixes googleapis#1133)
stephenplusplus
pushed a commit
that referenced
this issue
May 1, 2020
…1133) (#1135) * test(bucket): failing test for #1133 * fix(bucket): only disable resumable uploads for bucket.upload when inspecting the file size (fixes #1133) * text(bucket): Applied patch from @stephenplusplus - see #1135 (comment)
gcf-owl-bot bot
added a commit
that referenced
this issue
Jun 24, 2021
) Fixes #1134 🦕 Removes the commit body and relative PR# from the commit message. For example, for this commit: googleapis/synthtool@9763f20 `post-processor-changes.txt` would contain ``` build: enable npm for php/python builds Source-Link: googleapis/synthtool@9763f20 ``` instead of ``` build: enable npm for php/python builds (#1133) * build: enable npm for php/python builds * update comment Source-Link: googleapis/synthtool@9763f20 ``` Source-Link: googleapis/synthtool@e934b93 Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:805e2e389eafefa5ed484c30b83a7a875e6b1c7ee125d812e8b01ecc531c3fac
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Jun 24, 2021
Fixes #1134 🦕 Removes the commit body and relative PR# from the commit message. For example, for this commit: googleapis/synthtool@9763f20 `post-processor-changes.txt` would contain ``` build: enable npm for php/python builds Source-Link: googleapis/synthtool@9763f20 ``` instead of ``` build: enable npm for php/python builds (#1133) * build: enable npm for php/python builds * update comment Source-Link: googleapis/synthtool@9763f20 ``` Source-Link: googleapis/synthtool@e934b93 Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:805e2e389eafefa5ed484c30b83a7a875e6b1c7ee125d812e8b01ecc531c3fac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/nodejs-storage API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Environment details
@google-cloud/storage
version: 4.6.0Steps to reproduce
bucket.upload
with a file size over theRESUMABLE_THRESHOLD
to upload/home/.config
is not writable the upload failsDo the same steps but with
file.createWriteStream
and a file stream and the upload works.From looking at the code,
bucket.upload
setsoptions.resumable
and that means the retry check infile.createWriteStream
doesn't work.Note I discovered this issue by trying a resumable upload on Cloud Run which doesn't allow writing to
/home/.config
which doesn't seem right!The text was updated successfully, but these errors were encountered: