fix!: default to resumable with no threshold #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
ddelgrosso1
reviewed
Apr 12, 2022
| @@ -362,8 +362,6 @@ export interface UploadOptions | |||
| destination?: string | File; | |||
| encryptionKey?: string | Buffer; | |||
| kmsKeyName?: string; | |||
| resumable?: boolean; | |||
| timeout?: number; | |||
There was a problem hiding this comment.
Was this accidentally removed? It is still documented below.
There was a problem hiding this comment.
not accidentally removed and still documented below because it's still part of the interface. it's declared on CreateResumableUploadOptions. I removed this because it's duplicated
ddelgrosso1
approved these changes
Apr 12, 2022
ddelgrosso1
pushed a commit
to ddelgrosso1/nodejs-storage
that referenced
this pull request
May 23, 2022
* fix: default to resumable with no threshold * fix documentaiton * linted file * fixed documentation typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.