Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: Refactor Upload Directory Sample for Improved Reliability #1867

Merged
merged 11 commits into from
Apr 13, 2022
Merged

samples: Refactor Upload Directory Sample for Improved Reliability #1867

merged 11 commits into from
Apr 13, 2022

Conversation

danielbankhead
Copy link
Contributor

No description provided.

@d-goog
build: Update engines from 8 to 10
2946b38 
Will update to 10 to 12 very soon, but this will prevent eslint issues today
@d-goog
refactor: Refactor Upload Directory for Improved Reliability
c853ced
@snippet-bot
Copy link

snippet-bot bot commented Apr 12, 2022 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/nodejs-storage API. labels Apr 12, 2022
@danielbankhead danielbankhead marked this pull request as ready for review April 12, 2022 23:07
@danielbankhead danielbankhead requested review from a team as code owners April 12, 2022 23:07
@danielbankhead danielbankhead mentioned this pull request Apr 12, 2022
Closed
@danielbankhead danielbankhead merged commit 640f7b0 into main Apr 13, 2022
@danielbankhead danielbankhead deleted the upload-directory-sample-update branch April 13, 2022 17:11
@danielbankhead danielbankhead mentioned this pull request Apr 13, 2022
Closed
@danielbankhead danielbankhead changed the title refactor: Refactor Upload Directory for Improved Reliability samples: Refactor Upload Directory Sample for Improved Reliability Apr 13, 2022
@danielbankhead danielbankhead added the samples Issues that are directly related to samples. label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbankhead @ddelgrosso1 @d-goog