Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unnecessary types #1879

Merged
merged 2 commits into from
Apr 20, 2022
Merged

refactor: remove unnecessary types #1879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2945a09
refactor: remove unnecessary types
shaffeeullah Apr 20, 2022
3317ca3
removed types
shaffeeullah Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,13 @@ export interface PolicyDocument {
signature: string;
}

export type GetSignedPolicyResponse = [PolicyDocument];
export type GenerateSignedPostPolicyV2Response = [PolicyDocument];

export interface GetSignedPolicyCallback {
export interface GenerateSignedPostPolicyV2Callback {
(err: Error | null, policy?: PolicyDocument): void;
}

export interface GetSignedPolicyOptions {
export interface GenerateSignedPostPolicyV2Options {
equals?: string[] | string[][];
expires: string | number | Date;
startsWith?: string[] | string[][];
Expand All @@ -99,12 +99,6 @@ export interface GetSignedPolicyOptions {
contentLengthRange?: {min?: number; max?: number};
}

export type GenerateSignedPostPolicyV2Options = GetSignedPolicyOptions;

export type GenerateSignedPostPolicyV2Response = GetSignedPolicyResponse;

export type GenerateSignedPostPolicyV2Callback = GetSignedPolicyCallback;

export interface PolicyFields {
[key: string]: string;
}
Expand Down
3 changes: 0 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,6 @@ export {
GetFileMetadataResponse,
GetFileOptions,
GetFileResponse,
GetSignedPolicyCallback,
GetSignedPolicyOptions,
GetSignedPolicyResponse,
GenerateSignedPostPolicyV2Callback,
GenerateSignedPostPolicyV2Options,
GenerateSignedPostPolicyV2Response,
Expand Down