build: Streamline mocha config
#1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
ddelgrosso1
reviewed
May 2, 2022
| @@ -26,13 +26,16 @@ | |||
| "google storage", | |||
| "storage" | |||
| ], | |||
| "mocha": { | |||
There was a problem hiding this comment.
What does moving this here vs the command line provide?
ddelgrosso1
reviewed
May 2, 2022
| @@ -26,13 +26,16 @@ | |||
| "google storage", | |||
| "storage" | |||
| ], | |||
| "mocha": { | |||
There was a problem hiding this comment.
What does moving this here vs the command line provide?
There was a problem hiding this comment.
It allows 2 things:
npx mocha <path-to-test(s)>without additional flags to type/remember- Easier IDE integration - IDEs no long require additional config in order to run
mochatests (which can change over time)
There was a problem hiding this comment.
Add, if mocha is globally installed (npm i -g mocha) simply typing mocha in the CLI will run the default tests (same as npx mocha)
|
Additional note/context: Mocha merges the config file ( |
ddelgrosso1
approved these changes
May 2, 2022
danielbankhead
added a commit
that referenced
this pull request
May 6, 2022
* test: disable resumable upload in acl test before (#1903) * build: Streamline `mocha` config (#1905) * build: Streamline `mocha` config * fix: Require `--require ts-node/register` first * refactor: Misc cleanup Co-authored-by: Denis DelGrosso <[email protected]>
ddelgrosso1
added a commit
to ddelgrosso1/nodejs-storage
that referenced
this pull request
May 23, 2022
* test: disable resumable upload in acl test before (googleapis#1903) * build: Streamline `mocha` config (googleapis#1905) * build: Streamline `mocha` config * fix: Require `--require ts-node/register` first * refactor: Misc cleanup Co-authored-by: Denis DelGrosso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for native
mochaconfig support - now we can usenpx mochawithout passing additional args/config