Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: update library to use Node 12 #1926

Closed
wants to merge 1 commit into from
Closed

build!: update library to use Node 12 #1926

wants to merge 1 commit into from

Conversation

alexander-fenster
Copy link
Contributor

Migrate library to Node 12

@alexander-fenster alexander-fenster requested review from a team as code owners May 13, 2022 19:24
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 13, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node8/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node8/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 13, 2022
@danielbankhead
Copy link
Contributor

Note: This work is tracked via #1899

@danielbankhead danielbankhead added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 14, 2022
@ddelgrosso1
Copy link
Contributor

This looks to already be contained in #1876 and this PR can probably be closed or redirected at the dropNode10 branch.

@alexander-fenster alexander-fenster deleted the migrateToNode12 branch May 16, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-fenster @danielbankhead @ddelgrosso1