Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "feat: support iterables in file#save (#2202)"" #2271

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

ddelgrosso1
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 commented Aug 11, 2023

Reverts #2270

BEGIN_COMMIT_OVERRIDE
feat: support iterables in file@save
END_COMMIT_OVERRIDE

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners August 11, 2023 18:03
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/nodejs-storage API. labels Aug 11, 2023
@ddelgrosso1 ddelgrosso1 force-pushed the revert-2270-revert-2203-feat-save-stream branch from b4f7c07 to 6e475b8 Compare August 11, 2023 18:05
@ddelgrosso1 ddelgrosso1 force-pushed the revert-2270-revert-2203-feat-save-stream branch from 6e475b8 to 0c0edb4 Compare August 11, 2023 18:06
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2023
@ddelgrosso1 ddelgrosso1 merged commit 4356dd0 into main Aug 11, 2023
19 checks passed
@ddelgrosso1 ddelgrosso1 deleted the revert-2270-revert-2203-feat-save-stream branch August 11, 2023 18:52
ddelgrosso1 added a commit to ddelgrosso1/nodejs-storage that referenced this pull request Aug 11, 2023
…"" (googleapis#2271)

* feat: support iterables in file#save (googleapis#2202) (googleapis#2203)

* Revert "feat: support iterables in file#save (googleapis#2202) (googleapis#2203)" (googleapis#2270)

This reverts commit c0d9d58.

* Revert "Revert "feat: support iterables in file#save (googleapis#2202) (googleapis#2203)" (googleapis#2270)"

This reverts commit 49327ff.

---------

Co-authored-by: Matthieu <[email protected]>
ddelgrosso1 added a commit to ddelgrosso1/nodejs-storage that referenced this pull request Aug 11, 2023
…"" (googleapis#2271)

* feat: support iterables in file#save (googleapis#2202) (googleapis#2203)

* Revert "feat: support iterables in file#save (googleapis#2202) (googleapis#2203)" (googleapis#2270)

This reverts commit c0d9d58.

* Revert "Revert "feat: support iterables in file#save (googleapis#2202) (googleapis#2203)" (googleapis#2270)"

This reverts commit 49327ff.

---------

Co-authored-by: Matthieu <[email protected]>
@ddelgrosso1
Copy link
Contributor Author

BEGIN_COMMIT_OVERRIDE
feat: support iterables in file@save
END_COMMIT_OVERRIDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants