This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
fix(test): fix language detection test #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing test started returning `haw` (Hawaiian?), so let's use the longer text :)
product-auto-label
bot
added
size: xs
sofisl
approved these changes
Apr 21, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
🤖 I have created a release *beep* *boop* --- ## [7.0.0](v6.3.1...v7.0.0) (2022-06-30) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#789) ### Features * support regapic LRO ([#798](#798)) ([9f1ddc1](9f1ddc1)) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#793](#793)) ([a2d079b](a2d079b)) * **test:** fix language detection test ([#779](#779)) ([b6df5e2](b6df5e2)) ### Build System * update library to use Node 12 ([#789](#789)) ([3060301](3060301)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release *beep* *boop* --- ## [7.0.0](googleapis/nodejs-translate@v6.3.1...v7.0.0) (2022-06-30) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#789) ### Features * support regapic LRO ([#798](googleapis/nodejs-translate#798)) ([9f1ddc1](googleapis/nodejs-translate@9f1ddc1)) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#793](googleapis/nodejs-translate#793)) ([a2d079b](googleapis/nodejs-translate@a2d079b)) * **test:** fix language detection test ([#779](googleapis/nodejs-translate#779)) ([b6df5e2](googleapis/nodejs-translate@b6df5e2)) ### Build System * update library to use Node 12 ([#789](googleapis/nodejs-translate#789)) ([3060301](googleapis/nodejs-translate@3060301)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
to GoogleCloudPlatform/nodejs-docs-samples
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [7.0.0](googleapis/nodejs-translate@v6.3.1...v7.0.0) (2022-06-30) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#789) ### Features * support regapic LRO ([#798](googleapis/nodejs-translate#798)) ([9f1ddc1](googleapis/nodejs-translate@9f1ddc1)) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#793](googleapis/nodejs-translate#793)) ([a2d079b](googleapis/nodejs-translate@a2d079b)) * **test:** fix language detection test ([#779](googleapis/nodejs-translate#779)) ([b6df5e2](googleapis/nodejs-translate@b6df5e2)) ### Build System * update library to use Node 12 ([#789](googleapis/nodejs-translate#789)) ([3060301](googleapis/nodejs-translate@3060301)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
to GoogleCloudPlatform/nodejs-docs-samples
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [7.0.0](googleapis/nodejs-translate@v6.3.1...v7.0.0) (2022-06-30) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#789) ### Features * support regapic LRO ([#798](googleapis/nodejs-translate#798)) ([9f1ddc1](googleapis/nodejs-translate@9f1ddc1)) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#793](googleapis/nodejs-translate#793)) ([a2d079b](googleapis/nodejs-translate@a2d079b)) * **test:** fix language detection test ([#779](googleapis/nodejs-translate#779)) ([b6df5e2](googleapis/nodejs-translate@b6df5e2)) ### Build System * update library to use Node 12 ([#789](googleapis/nodejs-translate#789)) ([3060301](googleapis/nodejs-translate@3060301)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
to GoogleCloudPlatform/nodejs-docs-samples
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [7.0.0](googleapis/nodejs-translate@v6.3.1...v7.0.0) (2022-06-30) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#789) ### Features * support regapic LRO ([#798](googleapis/nodejs-translate#798)) ([9f1ddc1](googleapis/nodejs-translate@9f1ddc1)) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#793](googleapis/nodejs-translate#793)) ([a2d079b](googleapis/nodejs-translate@a2d079b)) * **test:** fix language detection test ([#779](googleapis/nodejs-translate#779)) ([b6df5e2](googleapis/nodejs-translate@b6df5e2)) ### Build System * update library to use Node 12 ([#789](googleapis/nodejs-translate#789)) ([3060301](googleapis/nodejs-translate@3060301)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
to GoogleCloudPlatform/nodejs-docs-samples
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [7.0.0](googleapis/nodejs-translate@v6.3.1...v7.0.0) (2022-06-30) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#789) ### Features * support regapic LRO ([#798](googleapis/nodejs-translate#798)) ([9f1ddc1](googleapis/nodejs-translate@9f1ddc1)) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#793](googleapis/nodejs-translate#793)) ([a2d079b](googleapis/nodejs-translate@a2d079b)) * **test:** fix language detection test ([#779](googleapis/nodejs-translate#779)) ([b6df5e2](googleapis/nodejs-translate@b6df5e2)) ### Build System * update library to use Node 12 ([#789](googleapis/nodejs-translate#789)) ([3060301](googleapis/nodejs-translate@3060301)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
renovate-bot
pushed a commit
to renovate-bot/nodejs-docs-samples
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [7.0.0](googleapis/nodejs-translate@v6.3.1...v7.0.0) (2022-06-30) ### ⚠ BREAKING CHANGES * update library to use Node 12 (GoogleCloudPlatform#789) ### Features * support regapic LRO ([GoogleCloudPlatform#798](googleapis/nodejs-translate#798)) ([9f1ddc1](googleapis/nodejs-translate@9f1ddc1)) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([GoogleCloudPlatform#793](googleapis/nodejs-translate#793)) ([a2d079b](googleapis/nodejs-translate@a2d079b)) * **test:** fix language detection test ([GoogleCloudPlatform#779](googleapis/nodejs-translate#779)) ([b6df5e2](googleapis/nodejs-translate@b6df5e2)) ### Build System * update library to use Node 12 ([GoogleCloudPlatform#789](googleapis/nodejs-translate#789)) ([3060301](googleapis/nodejs-translate@3060301)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing test started returning
haw(Hawaiian?), so let's use the longer text :)(I used Google Translate, I hope what it gave me for "This is a test" makes sense!)