This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
Add v1p1beta1 samples #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 4, 2017 14:46
TODO: remove tests & command-line arguments for these functions
| @@ -73,240 +69,9 @@ function detectText(fileName) { | |||
| // [END vision_detect_document] | |||
| } | |||
|
|
|||
|
|
|||
| function detectFaces(fileName) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
beccasaurus
commented
Dec 5, 2017
samples/system-test/detect.test.js
Outdated
| @@ -193,7 +193,6 @@ test(`should detect crop hints in a remote file`, async t => { | |||
| test(`should detect similar web images in a local file`, async t => { | |||
| const output = await tools.runAsync(`${cmd} web ${files[5].localPath}`, cwd); | |||
| t.true(output.includes('Full matches found:')); | |||
| t.true(output.includes('URL: https://cloud.google.com/vision/docs/images/')); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
samples/detect.v1p1beta1.js
Outdated
| webDetection.webEntities.forEach(webEntity => { | ||
| console.log(` Description: ${webEntity.description}`); | ||
| console.log(` Score: ${webEntity.score}`); | ||
| if (webDetection.bestGuessLabels.length) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
approved these changes
Dec 5, 2017
ghost
removed
the
cla: yes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference, see Python sample Pull Request:
GoogleCloudPlatform/python-docs-samples#1211
Samples demonstrating Beta enhancements to Cloud Vision API
Web detection using file geographical metadata for improved results
Web detection printing new best guess labels
Full text detection with confidence scores
Safe search including new racy detection
Tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)