Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

[DO NOT MERGE] Remove v1p1beta1 samples #53

Closed
wants to merge 5 commits into from
Closed

[DO NOT MERGE] Remove v1p1beta1 samples #53

wants to merge 5 commits into from

Conversation

beccasaurus
Copy link
Contributor

Blocked by #52

  • Get OK from TW to remove

TODOs

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@ghost ghost assigned beccasaurus Apr 5, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2018
@lukesneeringer lukesneeringer added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2018
@codecov
Copy link

codecov bot commented Apr 5, 2018 •
edited
Loading

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #53   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          75     75           
=====================================
  Hits           75     75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9582a...74ab353. Read the comment docs.

@stephenplusplus
Copy link
Contributor

@Beccca any update on this one? Still relevant?

@alexander-fenster alexander-fenster mentioned this pull request May 18, 2018
Closed
@JustinBeckwith
Copy link
Contributor

@Beccca bump :) Is this still a thing?

@JustinBeckwith
Copy link
Contributor

If this is still something we need, please do let me know! Otherwise, I'm closing it out for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@beccasaurus beccasaurus

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beccasaurus @googlebot @stephenplusplus @JustinBeckwith @lukesneeringer