-
Notifications
You must be signed in to change notification settings - Fork 431
Move conditionally defined ndb helpers into their own module. #434
Conversation
|
||
from google.appengine.ext import ndb | ||
|
||
from oauth2client.client import Credentials |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@nathanielmanistaatgoogle PTAL, I addressed the comments. (UPDATE: Except for the one about string concat.) |
|
||
from google.appengine.ext import ndb | ||
|
||
from oauth2client import client as client_mod |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
You addressed it just fine; a counterargument is a perfectly valid form of addressing a comment. :-) Looks great otherwise (if you really want to keep the |
64cf8d9
to
01dc3a9
Compare
Did the rename (UPDATE: specifically |
01dc3a9
to
08dd3bb
Compare
08dd3bb
to
e5fb542
Compare
CredentialsNDBProperty = _appengine_ndb.CredentialsNDBProperty | ||
FlowNDBProperty = _appengine_ndb.FlowNDBProperty | ||
_NDB_KEY = _appengine_ndb.NDB_KEY | ||
_NDB_MODEL = _appengine_ndb.NDB_MODEL |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Move conditionally defined ndb helpers into their own module.
Towards #433.