Add warnings and helpers for prompt='consent'. #572
Conversation
theacodes
force-pushed
the
auth-approval-prompt
branch
from
2f20368
to
4353bf8
Compare
|
|
||
| def _check_for_approval_prompt(self): | ||
| approval_prompt = self.params.get('approval_prompt') | ||
| if approval_prompt: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
force-pushed
the
auth-approval-prompt
branch
from
4353bf8
to
f3448a0
Compare
| @@ -1843,6 +1843,22 @@ def __init__(self, client_id, | |||
| } | |||
| self.params.update(kwargs) | |||
|
|
|||
| self._check_for_approval_prompt() | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
First pass completed. |
theacodes
force-pushed
the
auth-approval-prompt
branch
2 times, most recently
from
b1ce684
to
ccddbc2
Compare
| @@ -1679,6 +1679,16 @@ def test_override_flow_via_kwargs(self): | |||
| self.assertEqual(client.OOB_CALLBACK_URN, q['redirect_uri'][0]) | |||
| self.assertEqual('online', q['access_type'][0]) | |||
|
|
|||
| def test__check_for_approval_prompt(self): | |||
| self.flow.params['approval_prompt'] = 'force' | |||
| self.flow._check_for_approval_prompt() | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
force-pushed
the
auth-approval-prompt
branch
from
ccddbc2
to
e9bcd2d
Compare
|
@nathanielmanistaatgoogle this should be ready for another look. I was going to wait on travis but it seems we've been put back in the slow lane. |
|
Travis is (finally) green. :) |
|
Thanks for all the reviews today, @nathanielmanistaatgoogle. I'll be cutting 3.0.0 tomorrow morning. |
Fixes #453
This is the last one for 3.0.0. After this, I'll send the release PR.
:)