This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Drop unittest2 dependency #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| import argparse | ||
| except ImportError: # pragma: NO COVER | ||
| raise unittest2.SkipTest('argparase unavailable.') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I'm satisfied. @jonparrott: will you be taking a look? |
| @@ -25,11 +25,11 @@ | |||
| import stat | |||
| import tempfile | |||
| import warnings | |||
| import unittest | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM, other than a couple minor |
dhermes
force-pushed
the
drop-unittest2
branch
from
42a0da0
to
1bca012
Compare
No longer needed since Python 2.6 support has been dropped.
dhermes
force-pushed
the
drop-unittest2
branch
from
1bca012
to
0f21a3d
Compare
|
@nathanielmanistaatgoogle I don't think @jonparrott will mind not reviewing this mindless change. FWIW I assign both of you just to reach one of you (and here I knew @pferate was interested as well). |
|
I didn't mind not reviewing it. As long as the test god is pleased. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer needed since Python 2.6 support has been dropped.
Fixes #609
/cc @pferate