Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dir(proto.Message) does not raise #302

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

software-dov
Copy link
Contributor

dir(proto.Message) defaults to dir(type)

Closes #296

dir(proto.Message) defaults to dir(type)
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@71591e1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             main      #302   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        22           
  Lines           ?       989           
  Branches        ?       220           
========================================
  Hits            ?       989           
  Misses          ?         0           
  Partials        ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71591e1...1700fb0. Read the comment docs.

@software-dov software-dov merged commit 80dcce9 into googleapis:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom __dir__ in 1.20.0 breaks when called on 'Message' instead of subclass
3 participants